fix(frontend): 修复 PR #18 审阅问题并补充回归测试
审阅意见逐项修复: 1. 主题包安装丢弃用户 CSS inspectThemePackage 之前只解析 YAML 清单,ThemesView 安装时另外 生成一套硬编码调色板,用户提供的 CSS 被整份丢掉。现在定义单文件 格式(YAML 清单 + `---` + CSS),parseThemePackage 取出真实 CSS 并原样安装;CSS 安全校验提前到预览阶段;按内容识别并拒绝 ZIP。 2. 主题恢复竞态导致页面无 data-theme initTheme 之前没有 await loadCustomThemes,自定义主题还没进 allThemes,applyTheme 找不到主题直接 return。现在先同步落一个 内置主题兜底(不写 localStorage,避免冲掉用户存的自定义主题 id), 加载完成后再切到真正保存的那个;主题失效或列表加载失败时回退并 通过 themeLoadWarning 告知用户,不再静默。 3. Trace 建树依赖事件相邻顺序 后端真实顺序是 ModelCallStarted → ModelCallCompleted → Usage → ToolCall/ToolResult,工具在模型调用完成后才执行且并发跑,相邻性 不可用。改为按 model_call_id / parent_model_call_id / tool_call_id 关联;ToolResult 回填 ToolCall 的状态与耗时,结束后不再显示 running;SSE 断点恢复的孤立事件退回顶层而不是丢弃。 4. Trace 叶子节点无法查看数据 行的 click 是 `children.length && toggleExpand`,而详情 v-if 又 要求 `children.length === 0`,两个条件互斥。拆成 expandedNodes 与 detailNodes 两个状态集合;展开箭头改为独立按钮,行支持键盘 与 aria-expanded;引用节点补「定位」按钮。同时修正 Usage 卡片 字段(后端只发累计 token_usage)。 5. 引用定位逻辑三处重复且各自有缺陷 抽出 navigateToCitation(依赖注入,可独立测试)+ useCitationNavigation。 调用顺序固化:必须先 await loadFile 再 highlightBlock,否则 editor store 的 loadFile 末尾会把高亮清掉;loadFile 失败时不跳转。 AgentView / ChatView / AppShell 统一走这一处。 6. 插件命令 UI 重复实现 抽出 PluginCommandPanel 复用 PluginMcpPanel 的 schema 驱动表单, 删除 PluginsView 里的劣化副本。effect 现在真的执行 navigate / refresh(此前只拼成文本显示);补上必填校验与布尔字段初始值, 修正「显示否但不提交该键」的不一致。 补充回归测试 64 项(相关 spec 由 25 项增至 89 项),并对 2、3、4 三项 缺陷做了变异验证:把修复回退成原写法后对应测试确实失败。 涉及 traceService / theme store / themePackageService / pluginCommandForm / useCitationNavigation / TraceTimeline,其中后三个为新增文件。 vue-tsc -b、vitest(32 文件 182 项)、vite build 全部通过。
This commit is contained in:
@@ -2,18 +2,17 @@
|
||||
import { Connection } from '@element-plus/icons-vue'
|
||||
import AppIcon from '@/components/common/AppIcon.vue'
|
||||
import PluginMcpPanel from './PluginMcpPanel.vue'
|
||||
import PluginCommandPanel from './PluginCommandPanel.vue'
|
||||
import PluginSettingsPanel from './PluginSettingsPanel.vue'
|
||||
import { computed, onMounted, ref, watch } from 'vue'
|
||||
import { usePluginStore } from '@/stores/plugin'
|
||||
import * as pluginService from '@/services/pluginService'
|
||||
import type { PluginCommand, PluginCommandEffect } from '@/contracts'
|
||||
import type { PluginCommand } from '@/contracts'
|
||||
|
||||
const pluginStore = usePluginStore()
|
||||
const actionError = ref('')
|
||||
const activeTab = ref<'info' | 'settings' | 'commands'>('info')
|
||||
const pluginCommands = ref<PluginCommand[]>([])
|
||||
const commandOutput = ref<Record<string, string>>({})
|
||||
const isExecutingCommand = ref<string | null>(null)
|
||||
|
||||
onMounted(() => { void pluginStore.loadPlugins() })
|
||||
|
||||
@@ -21,8 +20,8 @@ watch(() => pluginStore.selectedPluginId, async (pluginId) => {
|
||||
if (pluginId) {
|
||||
activeTab.value = 'info'
|
||||
pluginCommands.value = []
|
||||
commandOutput.value = {}
|
||||
try {
|
||||
// 只为了标签上的命令数;执行逻辑在 PluginCommandPanel 里。
|
||||
const allCommands = await pluginService.listPluginCommands()
|
||||
pluginCommands.value = allCommands.filter((c) => c.plugin_id === pluginId)
|
||||
} catch { /* 命令加载失败时忽略 */ }
|
||||
@@ -54,36 +53,6 @@ async function uninstall(id: string, name: string) {
|
||||
catch (error) { actionError.value = error instanceof Error ? error.message : '卸载失败' }
|
||||
}
|
||||
|
||||
async function runCommand(command: PluginCommand) {
|
||||
isExecutingCommand.value = command.command_id
|
||||
commandOutput.value[command.command_id] = ''
|
||||
try {
|
||||
// Plugin 详情页没有笔记/选区上下文,按契约传空上下文。
|
||||
const result = await pluginService.executePluginCommand(command.command_id, {}, {})
|
||||
commandOutput.value[command.command_id] = describeEffect(result.effect)
|
||||
} catch (error) {
|
||||
commandOutput.value[command.command_id] = error instanceof Error ? error.message : '执行失败'
|
||||
} finally {
|
||||
isExecutingCommand.value = null
|
||||
}
|
||||
}
|
||||
|
||||
/** 效果白名单:只渲染契约允许的类型,未知类型统一按“已完成”处理。 */
|
||||
function describeEffect(effect: PluginCommandEffect): string {
|
||||
switch (effect.type) {
|
||||
case 'notification':
|
||||
return effect.payload.message
|
||||
case 'navigate':
|
||||
return `命令请求跳转到「${effect.payload.route}」`
|
||||
case 'refresh':
|
||||
return `命令请求刷新「${effect.payload.scope}」`
|
||||
case 'job':
|
||||
return `已创建后台任务:${effect.payload.job_id}`
|
||||
default:
|
||||
return '命令执行成功'
|
||||
}
|
||||
}
|
||||
|
||||
const hasSettingsContribution = computed(() =>
|
||||
pluginStore.selectedPlugin?.contributions.some((c) => c.type === 'settings_section') ?? false
|
||||
)
|
||||
@@ -195,35 +164,7 @@ const hasCommandContribution = computed(() =>
|
||||
</div>
|
||||
|
||||
<div v-else-if="activeTab === 'commands'" class="tab-content">
|
||||
<div v-if="pluginCommands.length === 0" class="empty-hint">
|
||||
<p>此插件暂无可执行命令。</p>
|
||||
</div>
|
||||
<div v-else class="command-list">
|
||||
<div v-for="cmd in pluginCommands" :key="cmd.command_id" class="command-item">
|
||||
<div class="command-info">
|
||||
<strong>{{ cmd.title }}</strong>
|
||||
<p class="subtle">{{ cmd.description }}</p>
|
||||
<div class="command-meta">
|
||||
<code>{{ cmd.command_id }}</code>
|
||||
<span class="locations">
|
||||
挂载于: {{ cmd.locations.join(', ') }}
|
||||
</span>
|
||||
</div>
|
||||
</div>
|
||||
<div class="command-action">
|
||||
<button
|
||||
class="button-secondary"
|
||||
:disabled="!cmd.enabled || isExecutingCommand === cmd.command_id"
|
||||
@click="runCommand(cmd)"
|
||||
>
|
||||
{{ isExecutingCommand === cmd.command_id ? '执行中…' : '运行' }}
|
||||
</button>
|
||||
</div>
|
||||
<div v-if="commandOutput[cmd.command_id]" class="command-output">
|
||||
{{ commandOutput[cmd.command_id] }}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<PluginCommandPanel :plugin="pluginStore.selectedPlugin" />
|
||||
</div>
|
||||
|
||||
<div v-else-if="activeTab === 'settings'" class="tab-content">
|
||||
@@ -347,46 +288,6 @@ const hasCommandContribution = computed(() =>
|
||||
.extension-title div { flex: 1; }
|
||||
.extension-title p { color: var(--color-text-tertiary); font-size: var(--font-size-xs); }
|
||||
|
||||
.command-list { display: grid; gap: var(--space-sm); }
|
||||
.command-item {
|
||||
padding: var(--space-md);
|
||||
border: 1px solid var(--color-border-default);
|
||||
border-radius: var(--radius-md);
|
||||
background: var(--color-surface-primary);
|
||||
display: grid;
|
||||
grid-template-columns: 1fr auto;
|
||||
gap: var(--space-sm) var(--space-md);
|
||||
align-items: start;
|
||||
}
|
||||
.command-info strong { display: block; margin-bottom: 2px; }
|
||||
.command-info .subtle {
|
||||
font-size: var(--font-size-sm);
|
||||
color: var(--color-text-secondary);
|
||||
margin-bottom: var(--space-xs);
|
||||
}
|
||||
.command-meta {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-md);
|
||||
font-size: var(--font-size-xs);
|
||||
color: var(--color-text-tertiary);
|
||||
}
|
||||
.command-meta code {
|
||||
padding: 1px 6px;
|
||||
background: var(--color-background-secondary);
|
||||
border-radius: var(--radius-sm);
|
||||
font-family: var(--font-ui-mono);
|
||||
}
|
||||
.command-output {
|
||||
grid-column: 1 / -1;
|
||||
padding: var(--space-sm) var(--space-md);
|
||||
background: var(--color-background-secondary);
|
||||
border-radius: var(--radius-sm);
|
||||
font-size: var(--font-size-sm);
|
||||
color: var(--color-text-secondary);
|
||||
white-space: pre-wrap;
|
||||
}
|
||||
|
||||
.empty-hint {
|
||||
padding: var(--space-2xl);
|
||||
text-align: center;
|
||||
@@ -396,6 +297,5 @@ const hasCommandContribution = computed(() =>
|
||||
|
||||
@media (max-width: 800px) {
|
||||
.detail-grid { grid-template-columns: 1fr; }
|
||||
.command-item { grid-template-columns: 1fr; }
|
||||
}
|
||||
</style>
|
||||
|
||||
Reference in New Issue
Block a user